Michael Kolupaev
Michael Kolupaev
> All engines should use KeyCondition. It is not necessary to have filter_actions_dag in SelectQueryInfo. To properly get filters you need use SourceStepWithFilter, then filters will be added to this...
TSAN error looks related: https://s3.amazonaws.com/clickhouse-test-reports/61632/690a8cf24b9402eac7479b0bbc62002b1ab3b7dc/stateless_tests__tsan__s3_storage__[4_5]/stderr.log . ASAN error seems to be the same: https://s3.amazonaws.com/clickhouse-test-reports/61632/690a8cf24b9402eac7479b0bbc62002b1ab3b7dc/stateless_tests__asan__[2_4]/stderr.log I'm guessing it's the `memcpySmallAllowReadWriteOverflow15()`. When called from `constantVector()`, `res_ref` is not padded (points into `std::string`)....
(Idk if my attempts at explanation are helping, feel free to just look at the added failing test 02996_index_compaction_counterexample and figure it out, instead of reading all this. It outputs...
Oops, turns out the cloud version of CH actually implements other mutation types in AlterConversions, not just RENAME_COLUMN (https://clickhouse.com/docs/en/guides/developer/lightweight-update). I pushed a commit to this PR that adds `AlterConversions::supportsMutationCommandType()` and...
Huh, that warning makes absolutely no sense to me. Shuffled the code a little to work around it, guess it's a clang issue.
All 4 test failures are unrelated: https://github.com/ClickHouse/ClickHouse/pull/64768 , https://github.com/ClickHouse/ClickHouse/pull/64770 , https://github.com/ClickHouse/ClickHouse/pull/64716 , https://github.com/ClickHouse/ClickHouse/pull/64771
The test failures about `system.zookeeper` are clearly related, but I couldn't reproduce them locally so far. Maybe it needs fast-test-like build with reduced dependencies? Maybe something's different in server config?...
> Maybe it needs fast-test-like build with reduced dependencies? Didn't help. > Maybe fast test passes some important arguments to clickhouse-test? Didn't help. > Maybe something's different in server config?...
In https://github.com/ClickHouse/ClickHouse/pull/58061 is another example where the server takes very different code paths in CI vs locally.
(Ok, reproduced the CI setup by copying the commands from the CI log shown in github actions (thanks to whoever put a `set +x` there!), found the dumb bug in...