Aleksandr Martirosyan comments

Results 7 comments of


                                            Aleksandr Martirosyan

fix(eslint-plugin): fix placement of lifecycle interface for subclasses

https://github.com/angular-eslint/angular-eslint/issues/1901

fix(eslint-plugin): fix placement of lifecycle interface for subclasses

I have manually tested the fix on my project but I wonder whether there is any possibility to test --fix with automated tests.

fix(eslint-plugin): fix placement of lifecycle interface for subclasses

Thank you. Will add the missing test cases accordingly.

fix(eslint-plugin): fix placement of lifecycle interface for subclasses

Yeah, sorry was on vacation without the pc. Will add the PR with tests tomorrow.

fix(eslint-plugin): fix placement of lifecycle interface for subclasses

@JamesHenry added the missing test case, the problem is only occurring when there is a class extension but no interface implementation at all.

distintUntilChanged: new overload missing in bundle

If you analyze the source you will see ``` export function distinctUntilChanged(comparator?: (previous: T, current: T) => boolean): MonoTypeOperatorFunction; export function distinctUntilChanged( comparator: (previous: K, current: K) => boolean, keySelector:...

tap-complete not called for last observable inside zip

I really dont think this is a bug. I see @jakovljevic-mladen tagged this as a bug but let me explain my analisis. the tap operators inner subscription has unsubscribe and...