Jim Rohrer

Results 12 comments of Jim Rohrer

I think we've experienced a similar issue to Issue 2 in @shaneyuan18 's comment above. Due to an update to CDK's AppSync libraries, our resolver logical resource IDs were changed....

+1 for this; we're in a similar situation where some of the clients accessing our API are doing so via cURL requests using a cookie jar, and some are coming...

I'm in the same boat. I have the redis.lua file overwritten in my repo, but it would be great if I didn't have to do that.

@akrishna1995 Can you re-run the tests? I added 3 more unit tests around the code and fixed the issues that popped up in the last run.

Curious if anyone has had a chance to take a look at this. Would appreciate another review.

I had almost forgotten about this. Thank you @humanzz for your feedback. I'll look into that script change and see if I can modify the code to make use of...

@humanzz The process using the AWS CLI is muuuuuch simpler. I don't have to rely on boto3, and I confirmed that the PyTorch training images have the AWS CLI installed....

@mohanasudhan Looks like all tests and lints are passing now, if you could take one last look.

@akrishna1995 I'd love to get a final review on this, if possible. Thanks!

@akrishna1995 Could I get a final review on this PR? I'd really like to get my internal projects off of my fork so I can start getting the more recent...