Roger Iyengar
Roger Iyengar
I just ran a test where I put the line `let start = Date.now();` right before the if statements at the start of the Google Analytics code. I then put...
The answer on that thread suggesting placing the snippet before the tag was quoting [Google's recommendation from 2014](https://web.archive.org/web/20140123065128/https://support.google.com/analytics/answer/1008080?hl=en-GB). However, [Google's current recommendation](https://support.google.com/analytics/answer/1008080?hl=en-GB) is to put the snippet right after the...
Just wanted to check in on this since it's been a while since this pull request has been responded to. Would you be willing to have the Google Analytics code...
Thank you for making this helpful library! I'm happy to give back with a small contribution. I hope this addresses the nits.
@aaronweihe No problem! I have just resolved conflicts.
ping @aaronweihe
@aaronweihe Are you still interested in this change? I can rebase it on top of the latest version of the code if so.
Thanks! I have signed the CLA. Is there anything else that you would like me to do?
@aaronweihe Are you able to merge this?
Just create a LifecycleRegistry instance, like the following: `LifecycleRegistry lifecycleRegistry = new LifecycleRegistry(0L);` Then start the Lifecycle with the line: `lifecycleRegistry.onNext(Lifecycle.State.Started.INSTANCE);` Call .lifecycle on your Scarlet.Builder() and pass in lifecycleRegistry....