Andras Katona

Results 21 comments of Andras Katona

Kafka 2.5.0 supports TLS enabled ZK, CC is creating the kafka Zookeeper client (KafkaZkClient), here we should pass the ZKClientConfig as the last param: https://github.com/linkedin/cruise-control/blob/migrate_to_kafka_2_5/cruise-control/src/main/java/com/linkedin/kafka/cruisecontrol/KafkaCruiseControlUtils.java#L526

@techguy0079 have you tried to pass ssl related zk config as system properties? these would be the basic props: ``` -Dzookeeper.client.secure=true \ -Dzookeeper.clientCnxnSocket=org.apache.zookeeper.ClientCnxnSocketNetty \ -Dzookeeper.ssl.keyStore.location= \ -Dzookeeper.ssl.keyStore.password= \ -Dzookeeper.ssl.trustStore.location= \...

@ijuma could you approve this change pls? Python based build executor died because of it: ``` OSError: [Errno 8] Exec format error: './gradlewAll' ```

@granthenke , could you take a look as well? Thanks!

@ijuma I've added the same shebang as gradlew has to gradlewAll. Could you check it pls? 🥺 🎅 🎄 😄

@omkreddy , @ijuma could you take a look? pretty small change, pretty pls :)

> Thanks @akatona84 for the PR. In order to add new configurations, we need to have a [KIP](https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals) Hey, thx for checking. Any idea/suggestions avoiding (too much) new configs because...

I totally agree that I have too many configs :D Yeah, it's happening quite often when testing, just starting the brokers and connect cluster and the health check of connect...

@urbandan , @lhunyady I've reworked the change, now it has the timeout exception and timeout based retries (instead of retry counts). Could you guys take a look please?

@mimaison , @viktorsomogyi I modified the change as you suggested, I'm curious how you like it this way. sorry for the loong delay