Andrew Mason

This is the general, and tracking, issue for [VEP-4](https://github.com/vitessio/enhancements/blob/main/veps/vep-4.md), [phase 3](https://github.com/vitessio/enhancements/blob/main/veps/vep-4.md#phase-3-restructuring-and-encapsulation), in which flags currently defined on the global `flag.CommandLine` in packages throughout vitess are moved simultaneously to a `pflag.FlagSet`...

Part of https://github.com/vitessio/vitess/issues/10697. Current flags: ``` $ git grep -E "\bflag\.[A-Z]" -- go/cmd/vtcombo/*.go go/cmd/vtcombo/main.go: schemaDir = flag.String("schema_dir", "", "Schema base directory. Should contain one directory per keyspace, with a vschema.json...

Part of https://github.com/vitessio/vitess/issues/10697. Current flags: ``` $ git grep -E "\bflag\.[A-Z]" -- go/vt/vttablet/tabletconn/*.go go/vt/vttablet/tabletconn/tablet_conn.go: TabletProtocol = flag.String("tablet_protocol", "grpc", "how to talk to the vttablets") ```

Switch flag definitions to be on pflag instead of flag in `package go/vt/wrangler`

1

Part of https://github.com/vitessio/vitess/issues/10697. Current flags: ``` $ git grep -E "\bflag\.[A-Z]" -- go/vt/wrangler/*.go go/vt/wrangler/vdiff_env_test.go: flag.Set("tablet_protocol", "VDiffTest") go/vt/wrangler/wrangler_env_test.go: flag.Set("tablet_protocol", "WranglerTest") ```

Switch flag definitions to be on pflag instead of flag in `package go/vt/workflow`

1

Part of https://github.com/vitessio/vitess/issues/10697. Current flags: ``` $ git grep -E "\bflag\.[A-Z]" -- go/vt/workflow/*.go go/vt/workflow/sleep_workflow.go: subFlags := flag.NewFlagSet(sleepFactoryName, flag.ContinueOnError) go/vt/workflow/workflow_test.go: subFlags := flag.NewFlagSet(testWorkflowFactoryName, flag.ContinueOnError) ```

Part of https://github.com/vitessio/vitess/issues/10697. Current flags: ``` $ git grep -E "\bflag\.[A-Z]" -- go/vt/withddl/*.go go/vt/withddl/withddl_test.go: flag.Parse() // Do not remove this comment, import into google3 depends on it ```

Add local devcontainer

2

## Description **Disclaimer!** I have never done this before, and I'm not sure about to do devcontainers in a project as large and multifaceted as vitess, but this is both...

Part of https://github.com/vitessio/vitess/issues/10697. Current flags: ``` $ git grep -E "\bflag\.[A-Z]" -- go/vt/vttablet/tmclient/*.go var TabletManagerProtocol = flag.String("tablet_manager_protocol", "grpc", "the protocol to use to talk to vttablet") ```

Part of https://github.com/vitessio/vitess/issues/10697. Current flags: ``` $ git grep -E "\bflag\.[A-Z]" -- go/vt/vttablet/tabletserver/vstreamer/*.go go/vt/vttablet/tabletserver/vstreamer/main_flaky_test.go: flag.Parse() // Do not remove this comment, import into google3 depends on it go/vt/vttablet/tabletserver/vstreamer/packet_size.go:var defaultPacketSize =...

Part of https://github.com/vitessio/vitess/issues/10697. Current flags: ``` $ git grep -E "\bflag\.[A-Z]" -- go/vt/vttablet/tabletserver/throttle/*.go go/vt/vttablet/tabletserver/throttle/throttler.go: throttleThreshold = flag.Duration("throttle_threshold", 1*time.Second, "Replication lag threshold for default lag throttling") go/vt/vttablet/tabletserver/throttle/throttler.go: throttleTabletTypes = flag.String("throttle_tablet_types", "replica",...