aj-thomas-8

Results 10 comments of aj-thomas-8

Hey I can work on this if no one else is already doing so

In the case of nested readers, if a read operation returns an EOF error, is it still supposed to break and return the EOF error?

Should calls to the panic macros in write/read operations be replaced by breaking and returning the appropriate error code instead? For instance, the write function of the `Packetizer` class calls...

In the write function of the packetizer class, will only `frame.size() / num_channels` samples be encoded and written to a packet for each frame? Do the rest of the samples...

That makes things a lot clearer. Thanks! And I'll add a comment to the packetizer code as well

Just to clarify, in the solution description, when you said the nested read/write calls in pipeline::Sender and pipeline::Receiver should repeat till the expected number of packets are read/written, you meant...

In the case of Fanout, wouldn't the expected number of samples written be `frame.size()` * number of output writers? Because if `Fanout::write(Frame frame)` were to return the number of samples...

Sorry, I’ve had a bunch of things come up so I won’t be able to work on this unfortunately