aj-rosado
aj-rosado
This looks good, I'm merging it. It will be part of an upcoming release. Thank you for the contribution!
Thank you for your contribution, I'm merging this change. It will be part of an upcoming release!
> This fix only applies to the generator, are you referring to #5887 for within the vault? > > I just tested it again and it seems to work: >...
> Yes, the Mac desktop application. Maybe there is a race condition, what if you replace `setImmediate` with `setTimeout` as in #5887. SetTimeout seems to solve it 😄 . With...
Thank you your contribution @dnicolson , this has been approved by QA and merged to master 🎉 This fix will be part of a future release. 😄
@noncenz thank you for your contribution. Your work is good to go. I've decided to just clean up the dev logging and add a validation. This will be included in...
Closing this PR. Will open a new one in the future only with the added test cases
🤔 The observable waiting logic should be on `BillingAccountProfileStateService`❓ could this affect any other part of the application? ❓should the fullSync be called there? If the sync takes long, it...
> This seems to be the context https://bitwarden.slack.com/archives/C02LPDKPML6/p1723199776246849 that triggered this PR, please correct me if I'm wrong! (I was on vacation when that discussion happened so I was a...
I have added a validation that in case the user hasPremium, it doesn't wait for the sync. Adding await seems to not solve the button loading behaviour