Aidan Haran

icon location Dublin, Ireland icon location Ruby on Rails developer. Open source maintainer.

Results 27 comments of Aidan Haran

Still problems with ActiveRecord::ConnectionNotEstablished (TinyTds::Error: failed to execute statement)

I'm unable to recreate the issue. The issue could be with your SQL Server database. Could you create a test-case using the script in https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/wiki/How-to-report-a-bug#minimal-reproducible-script and attach it to this...

Still problems with ActiveRecord::ConnectionNotEstablished (TinyTds::Error: failed to execute statement)

Hi Marco, Details of how to run a SQL Server instance using Docker is given in https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/wiki/How-to-run-SQL-Server-in-a-Docker-container. You could use that database instance to create a test case against.

Return of the N'' query issue on non unicode varchar columns

This issue isn't present in version 6.0 or 6.1 of the SQL Server adapter. It does happen in v5.2.1 as detailed in the original description. **SQL Server Adapter:** 5.2.1 **Rails:**...

Stored Procedure support for Rails 7 #load_async

We should be able to make use of https://github.com/rails/rails/pull/44446 to support async stored procedure calls.

fix-change-column-default

@nemesit Would you be able to add tests to the PR? The default constraint should be dropped when `nil` is passed rather than not altered. Could you confirm in your...

ActiveRecord::StatementInvalid: TinyTds::Error: Incorrect syntax near '0'

Unable to recreate the issue. Could you provide a test case (https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/tree/main/test/cases) or more information on the issue?

Nil variable @version_year is causing error when Rails try to load schema on the test database

Unable to recreate the issue. Could you supply a test or sample Rails app that demonstrates the problem?

Still getting "COMMIT TRANSACTION request has no corresponding BEGIN TRANSACTION"

@glennfu In order to investigate this it would be best if you could submit a PR with a failing test that demonstrates the issue you are having.

Still getting "COMMIT TRANSACTION request has no corresponding BEGIN TRANSACTION"

There are details on how to run the adapters unit tests at https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/blob/master/RUNNING_UNIT_TESTS.md You could add a test that: 1. Creates a trigger that tries to parse XML in a...

Still getting "COMMIT TRANSACTION request has no corresponding BEGIN TRANSACTION"

See https://github.com/aidanharan/activerecord-sqlserver-adapter-dev-box