Pavel Rosický

Results 109 comments of Pavel Rosický

@jeremy any update? this doesn't affect just Ruby 3, but even older Rubies with a recent net-smtp gem without this patch, there's no way to disable ```starttls_auto```, even with explicit...

@mikel just a reminder, could we include this bug-fix into the 2.8 release? I can rebase if necessary, thanks!

looks similar to my 2 year old PR :) https://github.com/mikel/mail/pull/1389

@solsticejc it's an internal limitation on how JRuby stores line numbers for coverage. See https://github.com/jruby/jruby/issues/6984 I agree that an exception is bad and it should be fixed on the JRuby's...

it should be fixed by https://github.com/jruby/jruby/pull/6991

MSG is a proprietary format, it would require some reverse engineering in order to do that and I'm not aware of any such tool for Ruby. but if you want...

nice find! I think you're right, the code should be removed. Could you add a test case according to your example to avoid further regressions?

I tested this change with 3 test suites (mail, actionmailer and redmine) wihout any regression. These methods aren't responsible for parsing, it should be just a lookup. Rescuing StandardError is...

the current parser can't handle a header like this ``` filename=\"30\" pretty kitten.jpg\" ``` in this case the filename format should be automatically forced to base64, something simmilar to ascii_compatible?...

Hi, @NfoCipher my first guess was it's https://github.com/mikel/mail/commit/dead487e02f592d9058fd07deedcde39b569d18d again but in your example, you're reading a pdf attachment in text mode ```ruby mail.attachments["yo.pdf"] = File.read("yo.pdf") ``` if I change it...