Results 73 comments of Gengkun

This is caused by `addInclude` in `ProvideSharedPlugin`, all provide modules will be added to compilation (and also child compilations) at `hooks.finishMake`. Actually the additional html-webpack-plugin asset won't affect anything, and...

Change htmlWebpackPlugin from child compiler to `compilation.executeModule` seems a better way to solve this

HtmlWebpackPlugin use child compiler to compile and execute to get the html asset, importModule (executeModule) is an alternative for child compiler, MiniCssExtractPlugin already switch to importModule from child compiler, HtmlWebpackPlugin...

One thing that wired to me is ConsumeSharedPlugin is using `hooks.thisCompilation` instead of `hooks.compilation`, what's the point if you provide shared modules in child compilation but only consume it in...

> I don't think we really need the esModule option here, let's do it always, because we already return reasons in getConcatenationBailoutReason Could you elaborate? Actually I didn't understand what...

@vankop I tried to refactor this but failed, I'm not very familiar with the code related to the `JavascriptParser`, can you give me more suggestions (add comments to specific lines...

Figured out why before failed, made a refactor, now the logic of replacing the destructuring assignment an import specifier is handled by `HarmonyDestructuredImportSpecifierDependency`: ```js import * as module from "./module"...

@vankop Yes, feel free to change on this PR

I think there is already have a warning for named export with JSON https://github.com/webpack/webpack/blob/7090328ba33f8887db2dcf41767ba72f7bfb90bd/lib/json/JsonParser.js#L62-L63 What about disable named export with JSON in next major and when `futureDefaults: true`? I will...