Aaron Gresch comments

Results 5 comments of


                                            Aaron Gresch

STORM-3544 Ability to find topologies with low worker uptime on UI

I think the reason was there was concern about the REST API fetching data about all the workers for all the topologies to get the min uptime. By having a...

STORM-3173: flush metrics to ScheduledReporter on shutdown

what was the status of this? I think work @srdo was doing addressed STORM-3173 possibly? Was that change committed?

exclude org.glassfish.web:javax.servlet.jsp from storm-autocreds hbase-server dependency

travis failure: Dependencies in LICENSE-binary that appear unused: org.glassfish.web:javax.servlet.jsp:2.3.2 org.glassfish:javax.el:3.0.1-b12

STORM-3186: Customizable configuration for metric reporting interval

This looks fine, except I'm not clear why this is only modified for ConsolePreparableReporter.

STORM-3186: Customizable configuration for metric reporting interval

Thanks. I also see ScheduledStormReporter using REPORT_PERIOD and REPORT_PERIOD_UNITS for setting this. Just wondering if we should switch that as well for consistency? I like the clarity of this change...