Devesh Agrawal comments

Repositories
Issues
Comments

Results 4 comments of


                                            Devesh Agrawal

Is there a good reason that the M3Reporter creates non daemon threads ?

HI @alexeykudinkin , can you achieve those semantics in a different way ? For example, do we need to have a "close" or a "flush" call ? What about the...

Is there a good reason that the M3Reporter creates non daemon threads ?

Also, I would like to note that just by making them as "non daemon" threads does not guarantee that the shutdown method will be called. So I think a fair...

Is there a good reason that the M3Reporter creates non daemon threads ?

Fair enough. I will make the daemon threads be opt in and user configurable, such that they do not get activated for each service. Good point on reducing the blast...

Presto UI not loading for running query

This appears to be in the metric fetch codepath. Should we add a general defense to the code to zero out not-present metrics to preclude this class of issues ?