Ken Rickard

Check your configuration registration. I had to make two changes: ## config/listeners.json ``` - {"listeners":["\\aleksip\\DataTransformPlugin\\PatternLabListener","\\PatternLab\\TwigNamespaces\\PatternLabListener","\\PatternLabListener"]} + {"listeners":["\\aleksip\\DataTransformPlugin\\PatternLabListener","\\PatternLab\\TwigNamespaces\\PatternLabListener","\\PatternLab\\Listener"]} ``` ## config/patternengines.json ``` - {"patternengines":["\\PatternLab\\PatternEngine\\Twig\\PatternEngineRule","\\PatternEngineRule"]} + {"patternengines":["\\PatternLab\\PatternEngine\\Twig\\PatternEngineRule","\\PatternLab\\PatternEngine\\Rule"]} ``` And I think this...

Re-testing.

Not sure what to make about the failing tests here. This would also require some documentation around how to use the variables, because I don't understand this code. That documentation...

Tests are failing here and always were. I'll try merging in 8.x-1.x to see, but I suspect they are still going to fail. Fortunately, we were able to fix d.o....

@hanoli In case you can't see the Travis results, this test needs to be fixed: ``` 1) Drupal\Tests\domain_alias\Functional\DomainAliasSortTest::testAliasSort Pattern matched as expected for example.com Failed asserting that an array is...

That test expects the alias pattern list to come back in a specific order. There are also numerous coding style violations in this patch.

Oddly, this test passes locally and on drupal.org -- https://www.drupal.org/project/domain/issues/3087449#comment-13717294 I wonder why it's failing here.

I do not understand the problem as currently explained. Can you please provide more detail.

I see. These aren't redirects, per se, (unless the alias is set to redirect to it's parent) but the link HREF is being rewritten. I wonder if instead of this...

Looks like this can be fixed by following https://www.drupal.org/node/3159012 UPDATE: No, the code already follows that pattern.