Artem Garmash
Artem Garmash
I believe this is done on purpose. This issue is addressed later in lesson 6
> Is this feature implemented in some hex editor you used before? I couldn't find anything like that to compare against. Your implementation seems like it only skips repeating bytes...
Just updated the implementation, now the UI looks like this: As for the following: > The code should also be using the existing search code for the hex editor. I...
@WerWolv nice, glad to hear! How shall we proceed with the PR then? Are you expecting some other people to review it?
@paxcut Let's consider the example I had when I decided to build this feature - skipping a long chunk of `0xFF`s in the raw flash dump. With the current implementation,...
> If I want to find the next example of the byte that is under the hex editor cursor there is no shortcut that will do that.You have to open...
> You are also not considering that if you are adding code to the search function itself that you can also implement the feature that if no value is entered...
Hey everyone, how shall we proceed with this PR?
@WerWolv Thanks for testing and merging! About the upper bound - literally this morning I was analyzing a 64 GB flash dump and felt the struggle of the blocked main...
I'm not a fan of adding the skip limit since it defeats the whole purpose of the feature - to skip the chunk of repeated bytes and be sure that...