affinityv

This is still a problem 2.5.1.61652 on Windows Server 2012 R2 was using close to 2 GB after being left running for some time.

> What's purpose of introducing different exit codes? Well, if any part of the script fails, it can be referenced back to the exit code; a successful exit should always...

> Thanks for the changes! > > I've noticed that ${SUDO} is wrapped in double quotes in your verison of the script. It results in 'command not found errors', I...

> Rebase your branch against notthebee:testing please (only keep the authoritative nameservers function and the related stuff) > > Also, have you tested it as follows? > > 1. Purposefully...

> vars.yml, and Okay, by vars.yml --- you mean vars: section of inventory.yml ?

The double read statements are awkward; assigning a variable to empty, checking that it meets the requirements and that the variable has a value to check before throwing an error...

Aside from the unusual "${SUDO}" issue, which seems odd to me, the quoting of variables is recommended by shellcheck.

Similar double work is happening in your "check_domain_dns" function; similar to the double "read" statements. The following doesn't use the authoritative nameserver, but it fixes other issues with the checks....

I've done a re-base as you wanted, but there are a few other differences aside from the above script variance. Also fixed an error on the user_password check that you...

That not used function, not ready to cull it yet for me. The other looks good. Still wondering if there is enough value using the authoritative nameservers, but I think...