Andreas Fabri

Results 479 comments of Andreas Fabri

Hello @nh2, Each package has a subdirectory `test`. And this one has a subdirectory `data`. So it should go [here](https://github.com/CGAL/cgal/tree/master/Stream_support/test/Stream_support).

Hello @houw, can you please put a self-contained cpp on gist.github,com so that we can try to reproduce.

I basically agree, but it is probably a little bit more complicated in case the `Parallel_tag` is used.

There are currently still several `assert(false)` where I have to rewrite code. And several comments starting with `AF:`.

I am wondering if we can remove [this file](https://github.com/CGAL/cgal/blob/master/CGAL_Core/include/CGAL/CORE/CoreIO_impl.h) with the functions that serialize the various CORE types. This is not documented.

The problem in the testsuite comes from, I believe, a bug in boost multiprecision. When reading "5,600" from a stream into a multiprecision rational the comma is not recognized as...

> The problem in the testsuite comes from, I believe, a bug in boost multiprecision. When reading "5,600" from a stream into a multiprecision rational the comma is not recognized...

> The platform `MSVC-2022-Preview-Release` will soon use Boost `develop` as well. There was a permission error on a `git-fetch`. @lrineau is that now working so that we can mark it...

In the link you @lrineau gave is written `[](unsigned char c){ return std::tolower(c); } // correct` so why do you see need for the two `static_cast`?

The ICE of VCV2015 comes probably from the fact that you use C++17 in