Andreas Fabri

Results 479 comments of Andreas Fabri

@loic-dubois @pougetma What is not offered by [`std::complex`](https://en.cppreference.com/w/cpp/numeric/complex) for that you come up with your own class ?

@pougetma can you please configure your text editor that it does remove trailing white space. And remove the current WS.

> We "only" have to modify the member names of our concept so that it fits the > one we need from std::complex. But the fact that sdt::complex provides more...

Do I get it right that [`Exact_complex` ](https://github.com/CGAL/cgal/blob/master/Hyperbolic_triangulation_2/include/CGAL/Hyperbolic_triangulation_2/internal/Exact_complex.h) is completely independent from `Complex_without_sqrt` and not used at all in your package?

Replacling with `std::complex` and modifying some functions compiles but I get the following warning from VC++. ```` 1>C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\MSVC\14.35.32215\include\complex(2054,24): warning C4996: 'std::complex::complex': warning STL4037: The effect of instantiating...

> I'm working on the move to std::complex, so please let me the token. The question is if we want to switch to `std::complex` or not. The warning gives me...

And what about aligning the names of functions to `std::complex` instead of the CGAL naming style? I would prefer to align.