Aaron Franks
Aaron Franks
Also interested in this for JavaScript, but in this case turning `if (something) doSomething();` into (note the braces): ``` if (something) { doSomething(); } ```
My preference would definitely be to have an option to control this. The JavaScript world has a wide variety of style guides and formatting preferences, so configurability would be great....
@AndrewRadev cool, thanks! I set `let g:splitjoin_javascript_if_clause_curly_braces = 'Sj'` in my vimrc, and joining is working as expected (no braces). But splitting does not create the braces for some reason.
Works great now, thank you! :+1:
I always use them when splitting so I didn't notice, sorry!
Thanks for the kind words and great feedback 🙏 * dots vs lines: I prefer dots personally, but I think this should be fairly easy to make configurable. * notes/project...
Instead of typing `envName` as `string` could you try `envName: keyof typeof env`? I think that should do the trick, typescript is rightfully complaining because not just any string will...
> there is not an easy way to handle such input from the CLI other than via JSON perhaps IMO being able to add bookmarks/outline via the CLI by passing...
Great feature idea, I could see this being pretty useful. I worry that an approach like `requiredWhen` that takes a string would be a bit too restrictive though. Maybe `requiredWhen`...
Something like the `requiredWhen` approach above could still be viable if we pass in the raw env. I'm not sure how we could do it in a type-safe way though....