aehanno

Results 12 comments of aehanno

@villebro , i will be glad to discuss with you about variable translation. Without adding translation on those varaibles, we have any translation on the second part of those sentence...

> @aehanno can you show a before and after of these changes? I'd like to understand how these translations are being picked up Hey @villebro, yes of course, I can...

As it is link to this issue https://github.com/apache/superset/issues/28431 @rusackas, Do you know what I can do about the Docker error? I didn't modify that part, so I don't understand why...

> @aehanno regarding the Docker issue, would you mind rebasing? I merge master and did the rebase

@rusackas It will impact what I did ? Do I need to change something on my PR Because I change the po files then with the po2json I generated the...

> Actually @aehanno, in looking at the PR files, there are a whole lot of changed files that look like they have nothing to do with translations. Maybe the rebase...

@rusackas Can be a solution to create a new branch then the pull request ? Instead of did the correction on this one

New PR here https://github.com/apache/superset/pull/28497

@rusackas There is my new PR I don't know if we waiting the end of the discussion about the .json file before merging mine ?

Hi @Ralkion, you just have to change your title to have the last test to pass the : nedd to be right after fix