Phil Williams

Results 5 issues of Phil Williams

Hello lwfinger, I have run into an issue, when unloading the driver I get the following segfault: ``` / # rmmod 8723bu [ 967.657737] RTL871X: module exit start [ 967.661925]...

The code makes some assumptions about skipping the ipv4 part. This causes the parsing to skip because the length is wrong. ![image](https://user-images.githubusercontent.com/11500738/121996100-25872a80-cdfc-11eb-9c29-b42519a399ca.png) Wireshark has no issue parsing it. Response is...

The SDL2 documentation says you can pass in NULL indices. ![image](https://user-images.githubusercontent.com/11500738/162645584-9c8570a8-6b97-4013-9bcb-55d068ae65c0.png) The go-sdl2 function assumes there is at least one indice passed in: ![image](https://user-images.githubusercontent.com/11500738/162645569-f20cb08b-9325-40fe-b9da-2b127f598f4c.png) I presume the fix is probably...

panic: runtime error: index out of range [0] with length 0 ``` goroutine 883 [running]:\ngo.bug.st/serial/enumerator.retrievePortDetailsFromDevInfo(0xc00011f3b0, 0xc000121560, 0x5, 0x0) /go/pkg/mod/go.bug.st/[email protected]/enumerator/usb_windows.go:351 +0x365 go.bug.st/serial/enumerator.nativeGetDetailedPortsList(0x0, 0x0, 0x0, 0x0, 0x0) /go/pkg/mod/go.bug.st/[email protected]/enumerator/usb_windows.go:299 +0x1b1 go.bug.st/serial/enumerator.GetDetailedPortsList(...) /go/pkg/mod/go.bug.st/[email protected]/enumerator/enumerator.go:31 ```...

What do you think about that? I am doing that locally on my end, but I can start making pull requests for them if you are interested? e.g. ``` const...

enhancement