Adam D Richman issues

Repositories
Issues
Comments

Results 2 issues of


                                            Adam D Richman

Beta v1.6.4 zip includes v1.6.3

It seems that the zip file available here (https://github.com/fikovnik/ShiftIt/releases/tag/version-1.6.4) is v1.6.3. To Clarify: the app that is packaged inside the zip is marked v1.6.3, and does not appear to have...

TraceContext::withSampled provides incorrect isShared and usesTraceId128bits parameters

`isShared` and `usesTraceId128bits` are being provided in the wrong positional order, which causes them to be set incorrectly. https://github.com/openzipkin/zipkin-php/blob/bad09acf421c79d360f53d1650fd4215e8be7579/src/Zipkin/Propagation/TraceContext.php#L200-L211 https://github.com/openzipkin/zipkin-php/blob/bad09acf421c79d360f53d1650fd4215e8be7579/src/Zipkin/Propagation/TraceContext.php#L33-L51