Adrian Tam

structural/proxy: fix typo for word handle

1

Fix typo for the word handle

#### Bug Report Checklist - [ ] Have you provided a full/minimal spec to reproduce the issue? - [ ] Have you validated the input using an OpenAPI validator ([example](https://apidevtools.org/swagger-parser/online/))?...

Consolidate the boilerplate construction of CheckResolvers

2

Sounds good. Can we add an issue to follow up and consolidate the boilerplate construction of CheckResolvers? _Originally posted by @jon-whit in https://github.com/openfga/openfga/pull/891#discussion_r1294883001_ Investigate whether we want to consolidate boilerplate...

Stop using proto objects for tuples and models

1

See https://protobuf.dev/getting-started/cpptutorial/#parsing-serialization We should (in another PR that is a pre-requisite of this one) wrap the `openfgav1.CheckRequest` object into a `openfgav1.ExtendedCheckRequest` that defines the `Equals` method. I've been wanting to...

Have consistent patterns in test optional value

1

Ideally, unit tests should have consistency in whether to specify optional values. > We have different patterns now. Some tests omit for brevity, and some tests don't. Let's just be...

Server emits 500 internal error for invalid store name on Streamed List Object

4

POST `http://localhost:8080/stores/ZAP%25n%25s%25n%25s%25n%25s%25n%25s%25n%25s%25n%25s%25n%25s%25n%25s%25n%25s%25n%25s%25n%25s%25n%25s%25n%25s%25n%25s%25n%25s%25n%25s%25n%25s%25n%25s%25n%25s%25n%25s%0A/streamed-list-objects` (note the encoded `\n` at the end of the store_id path parameter) will return 500 internal error with body ```json { "code": "internal_error", "message": "invalid header field value...

feat: allow per request specification of dispatch throttle threshold

1

## Description Add ability to allow per request specification on dispatch throttle threshold. This allows other software that uses OpenFGA as 3rd party library to override the dispatch threshold on...

feat: return HTTP code 422 if timeout due to throttling

2

## Description Instead of return HTTP 500, return HTTP code 422 if check request timeouts due to throttling ## References https://github.com/openfga/api/pull/151 ## Note - [x] DO NOT MERGE until https://github.com/openfga/api/pull/151...

Improve cyclomatic complexity of func (s *ServerContext) Run(ctx context.Context, config *serverconfig.Config)

6

As per https://github.com/openfga/openfga/pull/1552#discussion_r1578622449, the function ServerContext Run() https://github.com/openfga/openfga/blob/abf56641636fddef9340c4462364de1505c30442/cmd/run/run.go#L279 is highly complex and require refactoring. The [PR](https://github.com/openfga/openfga/pull/1552) slight reduces complexity. However, we require more systematic approach to make the server config...

_Originally posted by @jon-whit in https://github.com/openfga/api/pull/83#discussion_r1258460799_ Currently the documentations are OpenAPI based, we should consider moving/adding it to protobufs