Adrian Sergheev

Too lazy to open a pull req ; )

Possible retain cycle

1

Hi, there is a possible retain cycle in the lib. I am saying possible because it is probably my code, but I can't see where it comes from so I...

Discrepancy in the Examples

8

In the lib itself, the Reducer is a typealias, like so: `public typealias Reducer = (inout State, Event) -> Void` In the Examples however, they use a struct, with an...

Mem leak.

2

CameraKit Version: Last version. iOS Device: iPhone SE iOS Version: 12.2 ### Steps to Reproduce 1. Switch between photo/video ### Expected Behavior preview view should be released. ### Actual Behavior

The addition allows for this to compile: ``` func routes(_ app: Application) throws { app.get { req async in layout(title: "Home", content: home) } } ```

Hi. Good repo. Are there any plans on supporting more operations?

upgrade snapshot tests dependency (take 2)

1

https://github.com/finn-no/DemoKit-iOS/pull/8 https://github.com/finn-no/FinniversKit/pull/1319 https://github.com/finn-no/FinniversKit/pull/1307

Hi, centralManager.scanForPeripherals(withServices:, options:) which returns AnyPublisher acts as a hot observable since it executes original Apple provided scanForPeripherals(withServices:, options:) under the hood, which is a side effect. Alternatively, that call...