Adriane Boyd

Results 349 comments of Adriane Boyd

Adding a field to `Doc` is breaking, so I think this would need to wait until v4?

I think that `set_store_activations` is a really confusing name. Are you setting? Are you storing? Are you setting "store activations"? What are "store activations"? Are they "stored activations"?

Isn't it more along the lines of `set_activations_to_store` or `set_activations_to_save` or `set_store_activations_setting`?

Have you looked at the timing for this yet?

If the basic `pkg_resources` checks are extremely slow we can immediately stop working on it. (I don't think they will be, though.)

The merge undid some other edits?

I think there's too much danger for this to conflict with the pip flags. I noticed that this was just merged, maybe we can use this somehow instead? https://github.com/pypa/pip/pull/10771 Or...

There's no way for pip to resolve things without downloading so `pip install --dry-run` does the download but then doesn't install in the end, which isn't great here.

I think a separate command sounds easier, but the naming is hard. `download_url` still sounds too much to me like it might be downloading something. In general I think people...

Let's see, I'd never noticed this but we already have `spacy info model`, which is only intended for installed models, but maybe we can add a bit of info about...