Alex Donesky

Results 40 issues of Alex Donesky

We should only query `4byte.directory` if we have a full 4bytes of data in hex-string form to query against. 4byte.directory will return an unfiltered list of signatures without a full...

We should make `getTokenStandardAndDetails` fail faster if passed an address that does not point to any smart contract code.

- CHANGED: - Change the timeout for the fetch of tokenMetadata from token-api.metaswap.codefi.network from 10 seconds to 5 seconds, because this call stalls when querying token addresses it does not...

Cleans up `CurrencyRateController` test suite which has been intermittently failing quite frequently in CI: ![Screen Shot 2022-06-13 at 12 48 31 PM](https://user-images.githubusercontent.com/34557516/173413718-0f2c5834-1bc9-4bc1-bf43-d406056e09ee.png)

- FIXED: - **BREAKING**: Modify `getDetails` method in `ERC20Standard` class to return decimal strings rather than BigNumbers for the fields `decimals` and `balance` in the return object. Public controller methods...

- ADDED: - WIP (Will add tests if/when we decide to move forward) **Checklist** - [ ] Tests are included if applicable - [ ] Any added code is fully...

Per the conversation [here](https://github.com/MetaMask/controllers/pull/834#discussion_r877199312), we are failing to properly return values for contracts that contain methods like `name()`, `symbol()`, `tokenURI()` and `decimals()` that do not fully conform to one of...

![Screen Shot 2022-05-12 at 10 38 26 AM](https://user-images.githubusercontent.com/34557516/168114591-f40d9ab4-bfc6-49be-bec4-68782e3685ae.png)

- CHANGED: - Modifies the `addCollectibleContract` on the `CollectiblesController` to update `CollectibleContract` data if there is a previous entry in state that matches the address of the contract currently being...

Daniel Suchy discovered an error in Swaps where contract exchange rates with more than 15 significant digits was causing this error: ![image](https://user-images.githubusercontent.com/34557516/143066850-ec417e3b-d28f-4b6d-b069-a905bf708777.png) - We should make the TokenRatesController ContractExchangeRates robust...

team-assets