adombeck

Results 186 comments of adombeck

Sorry, I'm not working on SGX anymore and don't have the time to maintain this project, so treat it as abandoned.

> I'm currently working on a project that could potentially use a modified version of this or code inspired by this. Same here. @mdempsky Would it be possible for you...

We only allow the root user to send PAM requests to authd since https://github.com/ubuntu/authd/pull/311. The reasoning on that PR is "To prevent spamming the service with invalid authentication request". I...

Hi @shiv-tyagi, yes this looks good, thanks! One small thing: I would prefer to have a `Disabled` field instead of `Enabled`, so that the default value (`false`) means that the...

There should also be a new test case "Error_when_user_is_disabled" in https://github.com/shiv-tyagi/authd/blob/fed39218cfcce6c23e80e0d02fe2a2d748d3d912/internal/brokers/manager_test.go#L187-L190.

Oh and I don't think it makes sense to merge this before we have code which actually causes a user to be disabled (i.e. the command-line tool). If you still...

I rebased on main and resolved the conflicts caused by https://github.com/ubuntu/authd/pull/779.

Looks great, thanks for addressing the comments, @shiv-tyagi! I just added one more comment. Once you resolved that, I plan to merge this and create follow-up tasks for adding documentation...

Rebased on main, resolved conflicts and amended the commits which add the new API methods to add them to the new user service instead of the NSS service.

Hi @shiv-tyagi! No, this is not blocked by anything from your side. It's blocked by us being busy with the new release, and by the fact that more important things...