Andrey Dolgachev

Results 9 comments of Andrey Dolgachev

Closing in favor of https://github.com/angular/components/pull/30867

Closing in favor of https://github.com/angular/components/pull/31828

This does appear to work correctly at https://material.angular.dev/components/dialog/examples. Can you please provide a stackblitz with a reproducible example? It looks like you have a specific usage of this case in...

This looks good to me, including the slightly reduced top margin above the cards that you can see at https://ng-dev-previews-comp--pr-angular-components-32168-docs-ray9fv6x.web.app/cdk/categories but be good to get a 2nd internal opinion on...

@MeAkib can you please rebase and see if those errors go away? I re-applied the docs-preview too to regenerate the docs preview now and should again with your changes.

FYI this is causing a fair number of internal tests to fail.

This is still pending but I'll take a look this week as I'm back on rotation and try to fix the tests and merge if possible.

This does cause a lot of churn internally. In some cases unfortunately, the change in background conflicts with overlays on top of it (like date-picker). We'll need some more time...

Based on further feedback from @crisbeto on https://github.com/angular/components/pull/31469#discussion_r2179314807, I think the preferred solution will actually be https://github.com/angular/components/pull/31486.