Aditya Bansal

Results 19 comments of Aditya Bansal

Documenting a bit of discussion Harshit and I had on Zulip here so that we don't forget about it later. Basically conversation goes like this: @HarshitOnGitHub > "We are testing...

I have tried to cover all the spots where bots are exposed from to prevent SYSTEM_BOT profiles to be sent to frontend. This way we are trying to ensure that...

ohk, actually I forgot about removing the bell from the top of the second menu for reminders. I will get that in and then re organise commit history to have...

So actually I think I squashed that change to wrong commit. Currently that change is present in commit with title "reminders: Send message to Stream/PM when reminder is set." I...

Just doing a provisioning should make it work. `create_realm_internal_bots` script is run automatically.

Last commit add's a right chevron which looks like this: ![image](https://user-images.githubusercontent.com/17237412/38404390-64250d50-3987-11e8-9f51-85b3ab92075e.png) If this resonates with user's we will keep it. Basically the reason why it might not be wanted is...

I must note here that I wasn't able to test this out manually using the dev environment. When I tried out testing the nonce was being inserted into script tags...

The 'strict-dynamic' in the CSP policy used here prevents anything like ``` ``` Unless this script tag also had a nonce or was run by another script tag which had...

Look into design of `setup.py` page vs `edit the yaml` page. Setup page: ![Screenshot from 2019-10-18 19-03-14](https://user-images.githubusercontent.com/17237412/67098585-22c4d400-f1da-11e9-8423-d7bdff5f44c7.png) Edit YAML page (Looks much more clean and aligned): ![image](https://user-images.githubusercontent.com/17237412/67098682-3f610c00-f1da-11e9-86d8-a932acaa9235.png) Also maybe we...