Alan Deutscher

Results 43 comments of Alan Deutscher

I'm not certain about is the icon choice for a link. Not familiar enough with FontAwesome. This PR also adds a few new properties (`is_symlink` and `exists`) that can be...

#19 ended up being due to another type of unreachable symbolic link, so adding the fix into this branch. The cause of the issue is that the `is_dir`/`is_file` methods of...

Phrasing question: "Dead Symbolic Link" or "Unreachable Symbolic Link"? I'm used to saying "dead", but that could just be a casual habit.

Using `--no-listing` and `--no-download` will also make #14 possible, though not as the default.

The cause of the issue is that the is_dir/is_file methods of DirEntry throw PermissionErrors when used on a walled-off symbolic link.

This might be a bit apples and oranges, but I had a control-C problem with my SimpleHTTPServer+ThreadingMixIn-based script. Ctrl-C-ing out of the script while a download was in motion would...

The hiccup is in the `get_relative_path` method: ``` def get_relative_path(file_path, base_directory): return file_path.split(os.path.commonprefix([base_directory, file_path]))[1][1:] ``` Replacing this function with `os.path.relpath` seems to fix things.

On Windows (Python 3.7.6), everything appears to go alright: * Running `python -m updog -d /` shares `C:\`, and subdirectories can be navigated into. * Running `python -m updog -d...

@Alveona Also just tested with a specific drive letter, more directly addressing #23. Sharing with `python -m updog -d T:\` successfully shares the T:\ drive on my Windows box and...

On a similar note, there'll be a 500 if the directory was replaced with a file. This seems less of a problem than the many requests that will come in...