Addison Chan
Addison Chan
Implemented in #19413, would like feedback. Thanks!
It seems to me that saving doesn't occur if autosave is disabled. Saving happens in `s:close_window` [1], which is only called via autoload when autosave is enabled [2]. It seems...
I have a fix here, if anyone wants to try. The fix isn't perfect; there's redundancy in saving files if the autoexit command is used. I'm not good with vimscript,...
Hey! I was thinking of picking up this issue. How can I reproduce it? I've tried the following methods in a testing environment (please correct me if there's a better...
I attempted to add some [documentation](https://github.com/Cal-CS-61A-Staff/ok-client/wiki/ok_test)
I figured out most of it; went with storing the state of moves. Quick question: why does `game_scene` handle reading and writing savestate files? Why is it not handled in...
Got it, thanks all. I'm leaning towards replacing savestate with just PGN. I'm curious about the usecase for FENs, since it seems like that's only good for analyzing next moves...
While implementing this, I realized that it seems that the UI is handling events twice during PVP: once for white and once for black. Can we just drop all events...
On implementation, I noticed that communication is done through sending Squares instead of BitMoves. I assume this is to allow for future portability? Conversion to bitmoves lets us reduce on...
@rmadhwal I'm not entirely sure there would be an ordering conflict? If the protos are delivered via something like TCP, this would never occur, right? Nevertheless, the states can get...