Adam Sachs
Adam Sachs
@earmenda thanks for addressing the feedback - i think this looks just about good to go, besides one mypy issue it seems. i also put down one minor [comment](https://github.com/ethyca/fides/pull/1433#discussion_r999802787) about...
@ThomasLaPiana pretty sure the test failure here is unrelated - but not sure if you've got ideas on whether we should do anything else here to verify this won't break...
this could probably use a bit of polish, but wanted to at least first make sure no one saw any red flags with this incremental update!
ok @pattisdr i _think_ the update to use the custom encoder at the DB engine level is looking good, per our discussion yesterday! (tests seem to be passing). would like...
> lots of failing DSR 3.0 tests 😬 whoops, the tests i ran locally were far too narrow :( i'll take a closer look, sorry for asking prematurely!
> The Admin UI types/code changes are pretty solid. I didn't UAT the UI though so you should just grab a quick screenshot and get some eyes from @Kelsey-Ethyca or...
merging, discussed with @Kelsey-Ethyca that she will UAT once it's on `main` and this is a relatively low-risk update in any case 👍
some very preliminary research points to the "proper" support for this functionality still being in the backlog for github: https://github.com/github/feedback/discussions/9098 this post seems to point to a potential solution with...
interestingly, in testing this it seems that a user needs to now opt-in to enable actions on their forked repository (see screenshot). perhaps this is a good enough mitigation? if...
for what it's worth, i tried out the 'if' conditional workaround on a test fork repo: https://github.com/adamsachs/fidesops_forked_test/commit/2325c71302b0ba2ad112433afd6aaf5494291f73 and it seemed to work in that the action was skipped: https://github.com/adamsachs/fidesops_forked_test/actions/runs/2163901775