Adam McMaster

Results 33 comments of Adam McMaster

> Override would be acceptable if MIME type is validated, perhaps against a list of known & supported MIME types. That list might also be useful as part of a...

We'll need to think about how best to implement this. Presumably we'll need to check the filenames for a `.json` extension. I think we have three options: 1. Add a...

I'm reopening this as I just ran into the same issue. It looks like sometimes (but not always) the etag returned by `.where()` isn't valid when actually trying to save...

To be clear, this isn't an API bug. The client should silently reload the subject as needed.

`reload()` does hit the API again: https://github.com/zooniverse/panoptes-python-client/blob/master/panoptes_client/panoptes.py#L834 It's the same as calling `.find(id)` again. I'm not sure why the etag is wrong sometimes when it's usually fine most of the...

> Could the client rescue this specific error and retry with a reload() once say, then raise if still errors? This would make the client more robust and cut down...

For reference here's how I'm working around it: ```python for retry in (True, False): try: ... make changes to subject ... subject.save() except PanoptesAPIException: if retry: # Reload the subject...

One problem with this approach is that the client DOES retry the failing requests with a backoff interval, but they always fail until you call `reload()`, so it takes the...

In fact with the backoff it would be fewer requests to just call reload first every time.

@PmasonFF Did you actually remove the python-magic package at some point? If so I think you need to still have it installed, even if you then install python-magic-bin on top...