Adam Klein

Results 40 comments of Adam Klein

I think I found the problem. MobX 6 works differently. Need to update the docs and library. You need to call makeAutoObservable instead of using decorators: https://stackblitz.com/edit/angular-ze5a9c?file=app%2Fapp.store.ts

Hey, that's an interesting idea, so basically you want the route and params to be observables?

Try: ``` constructor(private router: Router) { router.events.filter((event) => event instanceof NavigationEnd).subscribe( (e) => this.routeListener(e) ); } @action private routeListener(event: NavigationEnd) { this.url = event.urlAfterRedirects; } ```

Although it should work with arrow function as well.

If anyone feels like doing a PR - we can include the RouterStore in the library. But need unit tests :)

Hi @funkizer , can you share the code that fails? I'd like to see the configuration there. Thanks

Strange, because node should open the `main` entry in `package.json` which points to the umd bundle. For some reason it's using the `jsnext` / `module` which point to the compiled...

Strange, I wonder why does angular universal require the UMD bundle? Can you share a repository so I can reproduce the error? Thanks On Fri, Mar 16, 2018 at 7:02...

I tried: ``` import {MobxAngularModule} from 'mobx-angular/dist/mobx-angular.umd.js'; ``` But then I got a different error: ``` ERROR in : Unexpected value 'MobxAngularModule in /Users/adamklein/projects/mobx-universal-starter/node_modules/mobx-angular/dist/mobx-angular.umd.js' imported by the module 'AppModule in...

I have no experience with Universal. If anybody wants to make a PR to solve #51 I will be happy to merge - and maybe it will solve this. I...