Adam Gemmell
Adam Gemmell
From the perspective of a local user it seems like it'd be better to attempt to checkout origin/master than skipping, though I can see this might mask unintended behaviour when...
Makes sense - I'll see if I can ensure that the build failing just skips the current benchmark
Just a heads up - I'm waiting for permission from my company to commit code to this repo before I can post a patch unfortunately. I'd expect a couple weeks...
Hi, sorry about that! I advised c272 to share the implementation first as the best way to move the discussion forwards. We should have followed the contributor's guide a bit...
Both upstreams have been merged, so I think this can be too now. Thanks!
r? @ehuss (nvm, I forgot a file 🙃)
> With the change in this PR, proc-macros and build scripts will start using the standard library from the sysroot. I think this is already the case. It looks like...
From my perspective rustc already treats core/std/others as special when it comes to the sysroot and attributes like `#![no_std]` or `#![no_core]`. In addition, these crates are versioned with the compiler...
> if a user's custom std doesn't support a target and the user wants to use a built-in target Looking back at this I'm not sure it's a concern. Whether...
Sorry for the silence here. First of all, I think there's two concepts I'm trying to express as one here that need to be separate: 1. Whether a target can...