Adam Budziak

Results 6 comments of Adam Budziak

Sorry, but your problem with `__init__` is due to the fact that you want to use wrong tool to solve a problem of duplication. The point of a constructor is...

Well, ending up with 12 parameters of a function is certainly an issue. However, whether it's worse or better than a hierarchy of classes is a matter of opinion. My...

Ok, so I did more digging, and it looks like some issue with `end_stream` value in `H2Stream.send_headers`. https://github.com/python-hyper/h2/blob/master/src/h2/stream.py#L863the function taken from the map here sets `trailers_sent` in the state machine...

It looks like because trailers now set `end_stream=True`, the response body isn't sent. I made a "fix" (quotes because I really have no idea what I'm doing). I'll check if...

TBH I just saw them in the other places where `end_stream=True` was used. I tried to understand more if I need to call these things, but it was too deep...