adam-bratin comments

Repositories
Issues
Comments

Results 4 comments of


                                            adam-bratin

Getting wrong `danger` object when Peril runs a Dangerfile

I am able to reproduce. I think I have root caused the issue: https://github.com/danger/peril/blob/45854ce43a389df8de582933b38a5af90dac5d5d/api/source/github/events/handlers/event.ts#L29-L32 When an event comes in that is not commentable the githubAPI is not created. This in...

Getting wrong `danger` object when Peril runs a Dangerfile

Hey @orta no problem real life happens. Just to give you some more context: It looks like the logic follows as this: - github_runner runEverything calls ```javascript //where req.body is...

Getting wrong `danger` object when Peril runs a Dangerfile

@orta any update on this?

Does it support circular data structure?

+1 I am also seeing this issue. I have tried composeWithDataLoader(composeWithMongoose(TC)) but it still throws the error