Andrei Tudor Călin
Andrei Tudor Călin
"control descriptor" sounds good to me. I'm not sure about the argument in `.control("something")`. I feel like the platform should multiplex key-value requests written to the control descriptor by itself...
Good catch. https://godoc.org/acln.ro/perf#Group.Add says: > For each Configurator, a new *Attr is created, the group-specific settings are applied, then Configure is called on the *Attr to produce the final event...
I'm going to fix this as soon as I have a little time to review and merge #4 also. Thanks.
This is indeed quite confusing, and bad. It's probably a relic from before a refactor. All of these self-exec tests need to be checked out more intimately anyway (#12), so...
I like the idea very much! I had something similar in mind, but I didn't know the custom labels proposal ended up getting merged for 1.13. Great news. I wonder...
IANAL. Reading through the Google CLA, it seems to me like the agreement is made between the copyright owner or legal entity authorized by the copyright owner, and Google. If...
Oh, something else too. I only just now noticed that this vendors dependencies, but it is using modules as well. Isn't that strange? I thought modules and vendoring were incompatible.
Thanks. This looks pretty good now. I guess the next question is if we want to have a `main.go` in the repository root, or if we should move it to...