Aaron Chong
Aaron Chong
> Looking at the current stack trace I still see AbpAuditing in there: >> at Abp.Runtime.Session.ClaimsAbpSession.get_UserId() >> at Abp.Auditing.AuditingHelper.ShouldSaveAudit(MethodInfo methodInfo, Boolean defaultValue) >> at Abp.Web.Mvc.Auditing.AbpMvcAuditFilter.OnActionExecuting(ActionExecutingContext filterContext) > > And also...
@natiki Is this resolved?
I don't think this solution fixes any additional edge cases. Both solutions pretty much target this specific edge case, where `StreamingResponse` does `listen_for_disconnect` and handles the disconnection in a way...
> If there are no pros to doing cancellation I believe you mean *not* doing cancellation. More accurately, it's temporarily shielding from cancellation. > I would prefer to just raise...
Sure. Thank you for your patience and prompt responses!
Are you using background tasks? This PR does not fix #1438.
My fix addresses the behaviour change in `StreamingResponse` caused by anyio integration. Your fix pre-empts the behaviour of `await recv_stream.receive()` for client disconnection in `BaseHTTPMiddleware` itself. That behaviour of `StreamingResponse`...
I've added a test for the specific situation this is supposed to fix. Actually, I don't think `StreamingResponse` should do this, since it's an intended feature of `MemoryObjectSendStream`. Usages of...
Well, it's not actually 1 LOC 😅 I have submitted PR #1710 to shield send "http.response.start" from cancellation in `BaseHTTPMiddleware`.
Hi, thanks for your PR! This repository uses [yarn](https://yarnpkg.com). Can you remove **package-lock.json** and run the following (instead of `npm install`) to update **yarn.lock**? ```shell $ yarn upgrade abp-web-resources@^3.5.0 ```