Alberto Contreras
Alberto Contreras
> `hypothesis-jsonschema` doesn't support JSON Schema drafts newer than Draft 7. I assume that it is the case, as `$ref` is used along with other keywords in `$defs/bar/properties/pbar` It is...
I have updated the description with a schema containing the Draft version. I have realized that that schema seems to be not 100% correct as: ```py jsonschema.validate({"bar": {"foo": "asdf"}}, schema)...
This PR would benefit from the inclusion of https://github.com/canonical/cloud-init/pull/1604 in order to easily allocate Ubuntu Pro instances for integration-testing.
I have integrated the future UA API to execute `auto-attach` programmatically as we agreed. The implementation is backwards compatible if `ubuntu-advantage-client`'s version is < `v28.0`, that means we could merge...
Thanks for the review, @blackboxsw. I have addressed your comments and refactored `_should_auto_attach` to except `UserFacingError` exceptions instead of the generic `Exception`. This PR is ready to be reviewed after...
Force-pushing to retrigger CI.
Thanks for the review, @blackboxsw! > 1. minor comment on your existing PR related to how we redact tokens in our integration logs. > > 2. some comments on how...
> 1. please set back `additionalProperties: false` on `features` schema as it doesn't make sense to allow properties that we just log that we will ignore. Done. > 2. Please...
> I do think the one final review blocking this PR is that auto_attach (PRO) images still need to be able to specify 'config' settings. Can you please factor that...
> Thanks for this @aciba90 . I think we minimally need a unittest that'll exercise enable response and exit 1 when a service is already enabled as that should have...