John Matherly

Results 20 comments of John Matherly

Yes, Shodan Monitor does what you outlined - filter out private IPs before using this Python library to call the API. It would probably be a good idea to have...

Yes, it would be nice to have. I think we could just filter out private IPs by parsing them first w/ the `ipaddress` module.

There are some challenges: 1. The `shodan` package currently works across a lot of Python versions, including Python 2.7. 2. The dependencies for Pandas would substantially increase the size of...

Yes, it would be good to properly handle a missing file.

It's similar to providing GeoIP information about the banned IP. The information from InternetDB would tell the user whether the connection came from a compromised IP, VPN, etc. It can...

Ah I think I understand. Yes, it could definitely run in the background. It isn't necessary to run synchronously with the ban as the information isn't consumed during ban time....

Agreed. Actually, I think it would make life easier if we appended to any existing file instead of overwriting the data. That way you don't need to concatenate .json.gz files...

It looks like you edited the wrong download method in your pull request. The one you edited is responsible for the bulk data downloads (``shodan data download``). And yes, I...

You should be able to access the specific error message from the `APIException.value` property

I think that's because for some of those responses the body isn't JSON but you're right, we should use the JSON error message if available as that is typically more...