achillean
Warning before overwriting a file
I just downloaded 10k results before running out of credits. I didn't know that's why the download had stopped prematurely; I made a mistake and used shodan download again to the same file to continue from where I had left off.
Result: the file of 10k results was replaced with an empty file. But it's gzipped, so at least it's small!
AAAAAnyway, it would have really been preferred if the CLI had complained before blowing away the initial multi-megabyte .gz.
Agreed. Actually, I think it would make life easier if we appended to any existing file instead of overwriting the data. That way you don't need to concatenate .json.gz files together if you want to merge multiple files - you can just run the download request and output the results to the same file.
It looks like you edited the wrong download method in your pull request. The one you edited is responsible for the bulk data downloads (shodan data download). And yes, I don't think that will be necessary anymore but I'll keep this issue open until that code is changed.