Adrià Casajús

Results 19 comments of Adrià Casajús

Where do you place the fix? I'd like to try it out.

Seems to be the same as #90

It works for me. Looking at lib.rs it is exported [here](https://github.com/Koka/odbc-rs/blob/48fa92d0a3276428438a15a28a58ad0fca3631d3/src/lib.rs#L29)

I've updated the MR to use the same code as `flask_limiter` does to have both use the same code to parse the URI.

We cannot change this config like that. It will break already existing configs.

Hey, thanks for contributing! May I suggest a small improvement. At the top define ```python ACTIVATION_CODE_NUM_DIGITS=6 ``` and then we can do ```python str(secrets.randbelow(10**ACTIVATION_CODE_NUM_DIGITS)).zfill(ACTIVATION_CODE_NUM_DIGITS) ``` :+1:

Hey, nice PR. But as a general comment, there aren't any tests added. I would suggest to add some: - Creating the SMTPCredentials does what it's supposed to and that...

Hey, thanks for the PR! It seems to be a nice feature. I'll leave some comments: - The keyspace is too short. If we get to a million aliases we...

I probably didn't explain myself. - I start my rails app in dev - Open my browser and trigger a websocket connection to my "hijacked" controller - Keep the websocket...

Is is useful for people that are using data integrated into the app as templates. For instance for go-bindata users.