acartine

Results 6 comments of acartine

is there a way i can commandeer this? Seems author might be tied up?

> @acartine I think you'd be more than welcome to give it a go in a new PR ok i'll give it a shit. i'm on gmt+1 but hopefully it...

@benjaco from looking at the code more closely it appears there is an unclear configuration hierarchy if you look at the first few types in https://github.com/sqlc-dev/sqlc/blob/047d587dd7ec9ccd04c8a9930c2a599b607ac18f/internal/codegen/golang/postgresql_type.go#L44-L139 the go types and...

i think there is a bit more clarification need. would you prefer i do it on that issue instead of this one? in that issue you use the text/varchar example....

> I would guess that the not null checks here should be moved up as the first check > > [sqlc/internal/codegen/golang/postgresql_type.go](https://github.com/sqlc-dev/sqlc/blob/ec9d492c40168739f813a0dc75f4ccd601770573/internal/codegen/golang/postgresql_type.go#L236-L246) > > Lines 236 to 246 in [ec9d492](/sqlc-dev/sqlc/commit/ec9d492c40168739f813a0dc75f4ccd601770573) >...