Matthew Poremba
Matthew Poremba
v24.1? Should we rip the band aid off?
Added new unit test for the new data types.
This is ready from my side.
> Just the one comment seems to be missing or I'm missing it? Hmm, I must have messed up the rebase. I won't be able to update until Monday, unfortunately.
This is complete. I think @mattsinc just wanted one additional comment which I have added
Would be great to get this and the MFMAs in for v24.0. Should be my last PR before v24.0
FYI, I may not get to this until next week
#1138 fixes "Error 2". Not sure about the other error, have not seen it.
@mattsinc @v-ramadas These are the notes I took when diagnosing this issue. I thought they might be helpful
FYI: @nmosier pointed out to me via email that the XCR registers aren't being checkpointed. I attempted a hacky workaround to set XCR0 to the pre-checkpoint value but unfortunately the...