Aleš Bizjak comments

Results 35 comments of


                                            Aleš Bizjak

Deriving JsonSchema seems to break serde's "with" field annotation

I came across this today as well and while I think the error when this happens should (and easily can) be better and point to the way things should be...

git_submodule_update should call git_clone__submodule instead of git_clone to omit the path check

We also ran into this issue via the `cargo generate` tool which uses `libgit2` as its dependency. As I see it in `git_submodule_update` the submodule is cloned only if it...

HTTP/2 was not negotiated connecting to Go-based gRPC service

I am experiencing the same issue, even with enabling TLS config explicitly.

mobile_wallet: Use conventional naming for transaction types

This change would mean that we are introducing an incompatibility that we need to deal with. Why are we doing this exactly? It would mean that the new wallet only...

Automate regression testing for baking/delegation

How is this related to https://github.com/Concordium/concordium-node/issues/359 Can you please provide a description to #359 or delete it?

Make the `invoke_contract` public in `cis2client` so that custom methods can be called from cis2 contract.

I don't think it's right to make this public since invoking other methods does not have anything to do with cis2. However if I read your feedback more broadly, it...

Update Resource Accounting topic for Smart Contracts v1 and v0

I think I pretty much have to do it in the first version. But I'm not sure when it'll be done, although it is important since we do get some...

Add documentation for the serialization of transactions

I think it would be better if this was gathered in developer documentation (so there is one place to go get the documentation) rather than in docs folders in specific...

Rethink the Deletable abstraction

Deletable solves a different problem than Drop. Deletable applies to things in the contract's persistent state, i.e., the state that survives across contract updates. In contrast, Drop is to clean...

Add a reentrancy vulnerability example

@annenkov Do you still plan to do anything with this?