Abit

Results 420 comments of Abit

An idea is to add an index on `last_confirmed_block_num` field to `witness_index`, so the order will be automatically maintained. In addition, for better performance, carefully maintain a secondary index to...

A new comment added here https://github.com/bitshares/bitshares-core/pull/2045/files#r584147551 about using a secondary index or simply iterating on each block. (Just found it's not a new idea.)

E.G. code in `memo.cpp`: https://github.com/bitshares/bitshares-core/blob/173ff3d27a4ca076a62bffdcd22d8f315b239a68/libraries/protocol/memo.cpp#L76-L90 BTW the combination of a `(uint32_t &)` conversion and a `native_to_little()` call looks suspicious.

Related issue: https://github.com/bitshares/bitshares-ui/issues/393, which was closed by using `get_full_accounts` API. For common use case, `get_full_accounts` will be called once with subscription to receive future changes, so it should be good...

@pmconrad right now we don't have many MPA's or PM's in the system, so pagination for `get_call_orders_by_account_asset` API is not very useful. The pagination is to avoid changing it again...

> There can be at most one call_order per account and asset. Oh. Thought you're talking about another API. Yes, this one will return one or zero entry. I'm fine...

Due to https://github.com/bitshares/bitshares-core/pull/1749, the `get_limit_orders_by_account` API is needed asap.

Implemented `get_limit_orders_by_account` API via #2146 for 4.0 release. Moving the issue to the next release.

> >Also, I think a better approach could be to install a proxy before the API port. Existing proxy implementations typically come with a variety of supported authentication schemes. A...

https://github.com/steemit/steem/commit/0fb40572c74791f85a0152c5bceb68ec9331e6c3 is related.