Abi Noda comments

Results 126 comments of


                                            Abi Noda

Upsert nil in place of current value

😱 @jesjos Please let us know your findings.

Upsert nil in place of current value

@bvallier @jesjos Just checking on this... is it an actual issue?

Upsert nil in place of current value

@zdrummond @bvallier Does this only happen when you use `find_or_initialize_by`?

Updating does not fire callbacks with updated attributes

Ping @benedikt

Updating does not fire callbacks with updated attributes

@benedikt Would adding a `run_callbacks(:before_save)` to `#upsert!` work? Before line 8 of https://github.com/jesjos/active_record_upsert/blob/24d7faaaf6ca63f987a870c0f6c47e02e8d50b48/lib/active_record_upsert/active_record/persistence.rb#L8 I'm not familiar with this code but just an idea.

Updating does not fire callbacks with updated attributes

@benedikt Should the README be updated? See related – https://github.com/zdennis/activerecord-import#callbacks

Updating does not fire callbacks with updated attributes

Or I wonder if all callback support should just be removed since they don't work predictably or consistently? Instead of there being ambiguous partial support? That'd be easier and less...

Updating does not fire callbacks with updated attributes

Just to provide some more color to this, I'm currently looking at using https://github.com/attr-encrypted/attr_encrypted. I'm thinking through whether or not it works out of the box with `upsert`. It would...

Revert "Update to actions v2"

@BlueSnaps What does the PR solve?

Step won't run if previous step failed

@leopic Feel free to submit a PR with the README change!