Abhinav Gupta

Results 184 comments of Abhinav Gupta

Thanks for the report @aws5295! We'll work on addressing this. (Internal tracking task: GO-786.)

Hey @sywhang. Yeah, I meant the first case, but what's different between the two versions in the second case?

Derp. My bad. Fixing.

Hi there! Thanks for your question. Background: OnStart supports returning an error if you have a means of knowing, at start up time, whether your background process started up successfully....

Hello! We currently do not support this feature, but I think we might want to. This ties into two issue that have been discussed on the uber-go/fx project more: https://github.com/uber-go/fx/issues/725...

Just to confirm something: I think the original proposal had a typo. In it, the interface was supplied to fx.From. ```go fx.Provide(fx.Annotate( NewBaz, fx.From(new(Bar))), ), // Where, // type Bar...

Yes, that looks right @rossb83. Looking forward to the PR. Thanks!

> One comment I have for the decorators impl–not that anyone asked–is that there seems to be a lot of code duplication between constructors and decorators. There are limits to...

Excellent! Again, thanks for the PR. > What do you mean by "pin"? Oops, I meant module replacements. "Pin to X" (as in, "pin to branch X" or "pin to...