Abhishek Malik comments

Repositories
Issues
Comments

Results 3 comments of


                                            Abhishek Malik

Last Delivery was not successful. Not Authorized

+1 And yes I too use different emails for both.

Last Delivery was not successful. Not Authorized

Ok, so I just noticed the syntax of key being added here: ``` heroku config:add ASANA_USERS='[{"username":"GitHubUsername1", "key":"XXXXXXXX.XXXXXXXXXXXXXXXXXX"}, {"username":"GitHubUsername2", "key":"XXXXXXXX.XXXXXXXXXXXXXXXXXX"}]' ``` I was trying to use the `Personal Access Tokens` from...

zero max-height issue with toolbar popover menus

@phuocng I believe the issue is here: https://github.com/react-pdf-viewer/react-pdf-viewer/blob/da204fec47b326bfe88ea2a4451511db1a531fdb/packages/core/src/portal/PopoverBody.tsx#L46C61-L46C61 `document.body.clientHeight` here gives value of zero. It should be probably `window.innerHeight` perhaps 🤔 . Should be a quick one line fix 🤞...